@alexcjohnson let's review this once shape-drawing is done :)

@archmoj I just had a quick look at this - very nice! Let's not touch it until 1.54.0 is released, but as this doesn't impact features at all we can include it in a patch after that.

My primary question is about the hard-coded list in mocks_test - seems like we should be able to

• read in the list of all mocks from the filesystem - perhaps if this step is fast enough we can just have karma.conf.js do it before every test run and write the results to a file in tests/jasmine/assets?
• only list a set of mocks or patterns to ignore - and then over time we can reduce that to an empty list.

My primary question is about the hard-coded list in mocks_test - seems like we should be able to

• read in the list of all mocks from the filesystem - perhaps if this step is fast enough we can just have karma.conf.js do it before every test run and write the results to a file in tests/jasmine/assets?
• only list a set of mocks or patterns to ignore - and then over time we can reduce that to an empty list.

@alexcjohnson
That is a very good idea we could try in another PR.
At first I did try to adapt our image test for this purpose.
But it was rather complicated to acess the system files from the jasmine test.
I think the way the required mocks are listed is OK atm.
It is actually handy for fixing those many mocks.

That is a very good idea we could try in another PR.

🍻 fair enough - added to #4733 so we address it before considering that issue closed.

This looks great. You currently have the require statements for the mocks all commented out - can we enable the ones you've fixed already, just comment out the still-failing ones, and call this PR done?

This looks great. You currently have the require statements for the mocks all commented out - can we enable the ones you've fixed already, just comment out the still-failing ones, and call this PR done?

Done in efd8518.